Skip to content

Modernize DevDiv static analysis pipeline - #26304

Merged
Stella Huang (StellaHuang95) merged 1 commit into
microsoft:mainfrom
StellaHuang95:stellahuang95-modernize-static-analysis
Nov 18, 2026
Merged

Stella Huang (StellaHuang95) merged 1 commit into
microsoft:mainfrom
StellaHuang95:stellahuang95-modernize-static-analysis

Conversation

@StellaHuang95

Copy link
Copy Markdown

Summary

  • remove deprecated AutoApplicability@1 and VulnerabilityAssessment@0
  • move AntiMalware, Component Detection, CredScan, PoliCheck, security reporting, and security-log publication to the supported 1ES/MicroBuild SDL path
  • remove the explicit legacy TSA upload for retired codebase vscode-python-main while keeping template TSA disabled
  • keep the repository-specific Bandit task and its exact target/rules configuration, and publish its SARIF as the non-production BanditResults pipeline artifact

Coverage

DevDiv run 16070997 showed both the 1ES AntiMalware source scan and the legacy explicit AntiMalware task, policy-injected component detection alongside the explicit component task, deprecation warnings for the old Guardian task majors, and a TSA 412 because vscode-python-main is retired for the WiM transition.

The 1ES template now owns AntiMalware, Component Governance/Detection, CredScan, PoliCheck, SdtReport, and PublishSecurityAnalysisLogs with its supported task versions. The template also owns eligible Advanced Security publication; this change does not add AdvancedSecurity-Publish manually. Bandit remains explicit so its existing Guardian ruleset and exact python_files/test exclusion target stay unchanged. Its SARIF is copied to a supported non-production 1ES pipeline output for post-run review.

The supported 1ES PoliCheck surface does not expose the legacy optionsRulesDBPath input used for build/ci/static_analysis/policheck/exceptions.mdb, so that old task-only wiring is not carried forward. If that custom rules database is still required, it needs a supported 1ES/MicroBuild integration rather than another explicit legacy PoliCheck task.

The Trust Services Automation/WiM support incident and any retired-codebase follow-up are being handled separately. This PR does not change API Scan, triggers, agent pools, release or product publishing, the live pipeline definition, or cutover.

Validation

  • parsed build/azure-pipelines/devdiv/static-analysis.yml with PyYAML
  • prettier 2.0.2 --check build/azure-pipelines/devdiv/static-analysis.yml
  • git diff --check
  • Azure Pipelines YAML preview against definition 28955 completed successfully without changing the live definition; the expansion contains one Bandit task, one CredScan v3 task, one PoliCheck v2 task, one security report, one security-log publication path, no AutoApplicability, no Vulnerability Assessment, and no TSA upload

Tracking: microsoft/pyrx#10073

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@StellaHuang95 Stella Huang (StellaHuang95) added the no-changelog No news entry required label Nov 18, 2026
@rchiodo

Copy link
Copy Markdown

🔒 Automated review in progress — Rich Chiodo (@rchiodo) is auto-reviewing this PR.

@rchiodo

Copy link
Copy Markdown

Reviewed commit: d3bbf92eba985ebfa8958490cc838f6f10f9f348

Result: 🔴 could-not-verify

Verification details

Verification: Automated verification is best effort. The PR author remains responsible for testing.

Summary: [unavailable] Container verification could not start and local execution was not authorized for this PR HEAD: C:\Users\rchiodo\AppData\Local\Programs\Podman\podman.EXE --connection pyrx-automation failed: stderr: Error: unable to start container "b5e216358f2f1b62fce387a32932c451fed1b3bd5ad26b19d2f5f718d19f1a17": crun: open `memory.max` for writing: No such file or directory: OCI runtime attempted to invoke a command that was not found

Test runs: none recorded.

@rchiodo Rich Chiodo (rchiodo) left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via Review Center.

@StellaHuang95
Stella Huang (StellaHuang95) merged commit f87ce4b into microsoft:main Nov 18, 2026
58 checks passed
@rchiodo Rich Chiodo (rchiodo) added the review-auto:approved Automated review: no blocking findings (approval posted). label Nov 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog No news entry required review-auto:approved Automated review: no blocking findings (approval posted).

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants